Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation problem of Chan stack: Control of special case FF_MAX_SS == FF_MIN_SS in FatFileSystem #15397

Open
bulanek opened this issue Mar 31, 2023 · 3 comments

Comments

@bulanek
Copy link

bulanek commented Mar 31, 2023

Description of defect

Compilation problem in special case of configuration Chan stack of SD:
In FatFileSystem::statvfs is missing controll of special case of configuration Chan stack when FF_MAX_SS == FF_MIN_SS
#if FF_MAX_SS == FF_MIN_SS
buf->f_bsize = FF_MAX_SS;
buf->f_frsize = FF_MAX_SS;
#else
buf->f_bsize = fs->ssize;
buf->f_frsize =fs->ssize;
#endif

This change make Mbed OK.

Target(s) affected by this defect ?

NRF

Toolchain(s) (name and version) displaying this defect ?

What version of Mbed-os are you using (tag or sha) ?

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

How is this defect reproduced ?

@mbedmain
Copy link

@bulanek thank you for raising this issue.Please take a look at the following comments:

Could you add some more detail to the description? A good description should be at least 25 words.
What toolchain(s) are you using?
What Mbed OS version are you using?
It would help if you could also specify the versions of any tools you are using?
How can we reproduce your issue?

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'. This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information.

@bulanek
Copy link
Author

bulanek commented Mar 31, 2023

Please add control to
int FATFileSystem::statvfs(const char *path, struct statvfs *buf):

#if FF_MAX_SS == FF_MIN_SS
buf->f_bsize = FF_MAX_SS;
buf->f_frsize = FF_MAX_SS;
#else
buf->f_bsize = fs->ssize;
buf->f_frsize =fs->ssize;

@bulanek bulanek changed the title Add control of special case FF_MAX_SS == FF_MIN_SS in FatFileSystem Adaptation problem of Chan stack: Add control of special case FF_MAX_SS == FF_MIN_SS in FatFileSystem Mar 31, 2023
@bulanek bulanek changed the title Adaptation problem of Chan stack: Add control of special case FF_MAX_SS == FF_MIN_SS in FatFileSystem Adaptation problem of Chan stack: Control of special case FF_MAX_SS == FF_MIN_SS in FatFileSystem Mar 31, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2023

Hi @bulanek , would you create a merge request to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue Workflow
Needs Triage
Development

No branches or pull requests

3 participants