Attempt to support case-sensitive search #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is @rrthomas turf. I'm merely an admin for this project. |
hfiguiere
reviewed
Feb 20, 2018
| * | ||
| * Returns: 0 if the word is correctly spelled, positive if not, negative if error | ||
| */ | ||
| int enchant_dict_check_case_sensitive (EnchantDict * dict, const char *const word, ssize_t len) |
There was a problem hiding this comment.
I don't see how this compiles. Missing the semi-colon at the end.
|
And you can just squash the two commits, since the second fixes the first one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hfiguiere Would really appreciate if you could take a look at this. I tried adding support for a new
enchant_dict_check_case_sensitivemethod that would not break compatibility by altering the existing overload, so wrapper libraries like PyEnchant should be able to amend their API to something likeFixes #189