[ECP-9095] Unnecessary hyphen prepended to "Description" when "Refusal Reason" is not provided

[angusmellorEND]

Making your own contribution is easy, encouraged and greatly appreciated! We will put effort into reviewing and merging your PR quickly. For more info, please refer to the contribution guidelines: https://github.com/Adyen/adyen-magento2/blob/develop/CONTRIBUTING.md

Describe the bug
" - " is prepended to "Description" set in admin panel when no "Refusal Reason" is given.

To Reproduce
Steps to reproduce the behaviour:

1. Go to Admin Panel -> Error handling -> Gateway Refusal Reasons
2. Provide a Reason Code and Description, but leave the Refusal Reason field blank.
3. Place Order, forcing the Reason Code provided above with corresponding holderName as found in docs (here)
4. Observe the response. It is formatted as "message: - ", where is the description provided in step 2.

Expected behaviour
When Refusal reason is left blank, response should be formatted "message: ". " - " not included in the message

Magento version
2.4.5-p5

Plugin version
9.0.6

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: All
• Browser All

Smartphone (please complete the following information):

• Device: All
• OS: All

Additional context
Add any other context about the problem here.

[candemiralp]

Hello @angusmellorEND,

Thank you for creating this Github issue. We've created an internal investigation ticket for this.

Best Regards,
Can