Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border between navigation toolbar and tabs toolbar #647

Open
Hobbix opened this issue May 17, 2024 · 4 comments
Open

Border between navigation toolbar and tabs toolbar #647

Hobbix opened this issue May 17, 2024 · 4 comments
Labels

Comments

@Hobbix
Copy link

Hobbix commented May 17, 2024

See default_tabs_photon_alt.css

/* border between navigation toolbar and tabs toolbar */
:root:not([lwtheme])  #nav-bar {
  box-shadow: 0 calc(-1 * var(--tabs-navbar-shadow-size)) 0 color-mix(in srgb, currentColor 20%, transparent) !important;
}

:root[lwtheme] #nav-bar {
  box-shadow: unset !important;
}

This code no longer works for FF126+?
It looks like FF126+ now uses --tabs-navbar-separator-color and --tabs-navbar-separator-style for this?

@Aris-t2
Copy link
Owner

Aris-t2 commented May 18, 2024

Thanks for the note. Most tab settings are affected. I will post new files soon.

@Aris-t2 Aris-t2 added the BUG label May 18, 2024
@Aris-t2
Copy link
Owner

Aris-t2 commented May 18, 2024

Test 4.5.2 release: https://github.com/Aris-t2/CustomCSSforFx/releases/

@Hobbix
Copy link
Author

Hobbix commented May 19, 2024

I'm using a custom light theme and for some reason this code doesn't work for me. I still see the pale gray line under the active tab.

/* Fx 110+ - remove line below active tab */
#nav-bar:not([tabs-hidden="true"]) {
  position: unset !important;
}

This code removes the line between the navigation bar and the tab bar, but it removes the line from all tabs (active and inactive)

/* Fx 126+ */
:root[lwtheme] #nav-bar {
  border-top: 0px !important;
}

The solution from this thread worked for me: #552 (comment)
It removes the line only on the active tab. On inactive tabs the line is displayed.

/* Fx 126+ - remove line below active tab (custom light theme)  */
#TabsToolbar #tabbrowser-arrowscrollbox {
  margin-top: 1px !important;
  margin-bottom: -1px !important;
}

@Aris-t2
Copy link
Owner

Aris-t2 commented May 19, 2024

Every few Firefox releases Mozilla devs go crazy and change code for navigation toolbars border. It either a fixed border color, a background-image or a box shadow, that gets added or removed, causing all of this projects options to require fixes.

I did a few tests yesterday before uploading 4.5.2 release, but my tests only covered "my default" cases, other configurations might of course require additional or different approaches.

Good to hear you could solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants