Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL like s3::https://my-custom-s3/my-bucket/key/path #566

Open
huaxk opened this issue Mar 15, 2024 · 0 comments
Open

Invalid URL like s3::https://my-custom-s3/my-bucket/key/path #566

huaxk opened this issue Mar 15, 2024 · 0 comments

Comments

@huaxk
Copy link

huaxk commented Mar 15, 2024

When starting Worker when aws_endpoint is set like s3::https://my-custom-s3/my-bucket/key/path, throws error:
thread 'main' panicked at copy-artifacts/src/main.rs:31:26: Failed to download s3::https://my-custom-s3/my-bucket/key/path/pipeline: InvalidUrl

It should be that the aws_endpoint url without port cannot pass the verification.

The S3_ENDPOINT_URL regular expression:
^[sS]3[aA]?::(?<protocol>https?)://(?P<endpoint>[^:/]+):(?<port>\d+)/(?P<bucket>[a-z0-9\-\.]+)(/(?P<key>.+))?$
should be changed to:
^[sS]3[aA]?::(?<protocol>https?)://(?P<endpoint>[^:/]+)(:(?<port>\d+))?/(?P<bucket>[a-z0-9\-\.]+)(/(?P<key>.+))?$
to support this form of aws_endpoint url.

huaxk added a commit to huaxk/arroyo that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant