Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dual SIM] No incoming call notification for secondary SIM #167

Open
Megver83 opened this issue Sep 8, 2022 · 6 comments
Open

[Dual SIM] No incoming call notification for secondary SIM #167

Megver83 opened this issue Sep 8, 2022 · 6 comments

Comments

@Megver83
Copy link

Megver83 commented Sep 8, 2022

I installed the app from F-Droid, version 0.22, and synced with a bass watch. Till now, it works fine, but I get no incoming call notification and the app has all permissions.

Device is a Xiaomi Redmi Note 8 running LineageOS 18, Android 11.
Maybe related to #114 ?

@Megver83
Copy link
Author

OK, so I think I found something interesting. This phone is dual SIM, the watch notifies my incoming calls from one SIM, but not the other other one.

@MagneFire
Copy link
Member

Thanks for reporting the issue!
Great observation too!

This is an issue with the way we use PhoneStateListener where it picks the first SIM by default (https://github.com/AsteroidOS/AsteroidOSSync/blob/afb09f90f4b378bccbb07626f4776a5382432db5/app/src/main/java/org/asteroidos/sync/services/PhoneStateReceiver.java).

https://stackoverflow.com/questions/25009926/phonestatelistener-is-not-called-for-sim-slot-2 describes the same issue.

It seems that we need to create another instance of the listener and specifically listen for that SIM as well.

@Megver83 Megver83 changed the title No notification for incoming call [Dual SIM] No incoming call notification for secondary SIM Sep 15, 2022
@Megver83
Copy link
Author

Oh, so you were not aware of this. Glad to know there's a solution. Do you publish nightly builds or something? So I can test the app before there's a release, in case you wish so

@MagneFire
Copy link
Member

Indeed we were not aware of this issue.

We do not publish nightly builds, but we might be able to distribute self-signed apks when we get around to testing a solution.
Unless @jrtberlin knows a better method that could use the F-Droid infrastructure so that we don't get a signature mismatch.

@jrtberlin
Copy link
Member

I want to release a build on F-Droid anyway to get the recent changes published

@Megver83
Copy link
Author

Megver83 commented Oct 5, 2022

I thought this was going to be fixed in 0.23. Or is it going to be in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants