Support for setting cookies on 302 redirects #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking...Thanks for submitting. |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
* some refactoring motivation: better code structure changes: * abstract errors as enum instead of nested structs * make configurationa nested class * errors as static let * * move request, response, task to be nested under HTTPClient * rename HTTPResponseDelegate -> HTTPClientResponseDelegate * adjust tests * Update SwiftNIOHTTP.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently async-http-client does not support setting cookies on 302 redirect. Unfortunately this is required for some sites I track, based on Invision Power Board. That patch adds that support only for netty provider, but it is easy to port to others
This is example of that problem found in safari:
http://stackoverflow.com/questions/1144894/safari-doesnt-set-cookie-but-ie-ff-does