Skip to content

Ahc 78 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2011
Merged

Ahc 78 #11

merged 4 commits into from
May 5, 2011

Conversation

gailh
Copy link
Contributor

@gailh gailh commented May 4, 2011

Here are the fixes for the unit tests.

@jfarcand
Copy link
Contributor

jfarcand commented May 4, 2011

If fail to compile

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project async-http-client: Compilation failure: Compilation failure:
[ERROR] /Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[110,16] cannot find symbol
[ERROR] symbol : method setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] /Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[185,16] cannot find symbol
[ERROR] symbol : method setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] /Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/AuthTimeoutTest.java:[93,16] cannot find symbol
[ERROR] symbol : method setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] /Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/DigestAuthTest.java:[90,16] cannot find symbol
[ERROR] symbol : method setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] -> [Help 1]

Do I need to update Jetty version?

@gailh
Copy link
Contributor Author

gailh commented May 4, 2011

Oh I forgot...I had the latest jetty so i wrapped the array to get
lists....let me undo those changes and i'll recommit.

On Wed, May 4, 2011 at 2:20 PM, jfarcand <
reply@reply.github.com>wrote:

If fail to compile

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile
(default-testCompile) on project async-http-client: Compilation failure:
Compilation failure:
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[110,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[185,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/AuthTimeoutTest.java:[93,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/DigestAuthTest.java:[90,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] -> [Help 1]

Do I need to update Jetty version?

Reply to this email directly or view it on GitHub:
https://github.com/sonatype/async-http-client/pull/11#issuecomment-1102247

@gailh
Copy link
Contributor Author

gailh commented May 4, 2011

Ok I committed/pushed the fixes.

Gail

On Wed, May 4, 2011 at 2:24 PM, Gail Hernandez
gail.hernandez@liferay.comwrote:

Oh I forgot...I had the latest jetty so i wrapped the array to get
lists....let me undo those changes and i'll recommit.

On Wed, May 4, 2011 at 2:20 PM, jfarcand <
reply@reply.github.com>wrote:

If fail to compile

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile
(default-testCompile) on project async-http-client: Compilation failure:
Compilation failure:
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[110,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/BasicAuthTest.java:[185,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/AuthTimeoutTest.java:[93,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR]
/Users/jfarcand/workspace/async-http-client/src/test/java/com/ning/http/client/async/DigestAuthTest.java:[90,16]
cannot find symbol
[ERROR] symbol : method
setConstraintMappings(java.util.List<org.eclipse.jetty.security.ConstraintMapping>,java.util.Set<java.lang.String>)
[ERROR] location: class
org.eclipse.jetty.security.ConstraintSecurityHandler
[ERROR] -> [Help 1]

Do I need to update Jetty version?

Reply to this email directly or view it on GitHub:
https://github.com/sonatype/async-http-client/pull/11#issuecomment-1102247

@jfarcand jfarcand merged commit c766c38 into AsyncHttpClient:master May 5, 2011
cs-workco pushed a commit to cs-workco/async-http-client that referenced this pull request Apr 13, 2023
@ianpartridge
fix: length calculation of .string HTTPBody (AsyncHttpClient#11)
db60d3d 
Currently, if an `HTTPBody` is set to .string, the length is calculated as
string.count. In Swift, this is the number of extended grapheme clusters, not
the UTF8 byte count. Instead, we should use the count of the UTF8View, as the
bytes will be transmitted in this encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gailh @jfarcand