NettyAsyncHttpProvider issue during setting future.keepAlive() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgraded from 1.6.2 to 1.6.3 and now the problem is gone. However, it still seems that the setKeepAlive() was set incorrectly. I'll attach the commit to change the README. |
|
Hi, thanks for the contribution. I'm not sure about the change requested as it means we don't support keep-alive for chunk encoding or any server that aren't set the connection header. I can potentially make the behavior configurable, but can you explain in more detail your use case? Thanks! |
|
Right, I messed with HTTP 1.0 spec. In http 1.1 it is ON by default. Sorry for confusion, please, ingore the first two patches. However, update plz versions and the examples on the README to the latest one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the AsyncHttpClient is used Netty provider and Suspended REST connection, the Future never returns, even if the handler is returning STATE.ABORT.