ServiceCollectionExtensions.cs should not use the core namespace

[bteamsoftware]

It's generally considered bad practice to use namespaces within the core framework library when defining new types or extension methods. This is because there is a risk the framework introduces a type, interface, etc. of the same name causing a conflict with the custom library. The namespace in ServiceCollectionExtensions.cs should be changed to avoid using the Microsoft.Extensions.DependencyInjection namespace. I'm pretty sure there's a MS document that discusses this but I'm having difficulty locating it at the moment.

[lbargaoanu]

I remember the guidelines saying that DI extension methods should be in that exact namespace :) Anyway, that ship has sailed.

[jbogard]

Yes, the guideline is to use that namespace:

Note: Each services.Add{GROUP_NAME} extension method adds and potentially configures services. For example, AddControllersWithViews adds the services MVC controllers with views require, and AddRazorPages adds the services Razor Pages requires. We recommend that apps follow the naming convention of creating extension methods in the Microsoft.Extensions.DependencyInjection namespace. Creating extension methods in the Microsoft.Extensions.DependencyInjection namespace:

• Encapsulates groups of service registrations.
• Provides convenient IntelliSense access to the service.

[jbogard]

Source: https://learn.microsoft.com/en-us/aspnet/core/fundamentals/dependency-injection?view=aspnetcore-2.2#register-groups-of-services-with-extension-methods-1