Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Default state is no active index versions #4434

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rebeccahum
Copy link
Contributor

Description

Last missing piece of #3963.

Changelog Description

Plugin Updated: Enterprise Search

Initial state of Enterprise Search is no active versions.

@rebeccahum rebeccahum added the [Component] Search ChangelogTagID: 2373 label May 3, 2023
@rebeccahum rebeccahum force-pushed the search/default_to_no_versions branch from a77682a to 294f8a9 Compare May 3, 2023 23:39
@rebeccahum rebeccahum marked this pull request as ready for review May 3, 2023 23:48
@rebeccahum rebeccahum requested a review from a team as a code owner May 3, 2023 23:48
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #4434 (1f783cc) into develop (e24830b) will increase coverage by 0.13%.
The diff coverage is 15.87%.

@@              Coverage Diff              @@
##             develop    #4434      +/-   ##
=============================================
+ Coverage      28.78%   28.91%   +0.13%     
- Complexity      4604     4613       +9     
=============================================
  Files            270      270              
  Lines          20403    20425      +22     
=============================================
+ Hits            5873     5906      +33     
+ Misses         14530    14519      -11     
Impacted Files Coverage Δ
...ch/includes/classes/commands/class-corecommand.php 0.00% <0.00%> (ø)
search/includes/classes/class-versioning.php 86.55% <100.00%> (+0.19%) ⬆️

... and 3 files with indirect coverage changes

@rebeccahum rebeccahum force-pushed the search/default_to_no_versions branch 2 times, most recently from c288cfa to df565b7 Compare May 4, 2023 00:06
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@rinatkhaziev rinatkhaziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good but I think there's potential to simplifying things a bit, see my inline comment.

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sjinks sjinks force-pushed the search/default_to_no_versions branch from ad644f3 to 1f783cc Compare July 12, 2023 16:36
@rinatkhaziev rinatkhaziev removed their request for review August 8, 2023 18:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants