Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinePlanes: error when sample clip is a different dimension but compatible colorspace. #325

Open
Reel-Deal opened this issue Feb 2, 2023 · 2 comments

Comments

@Reel-Deal
Copy link
Member

Reel-Deal commented Feb 2, 2023

src = ColorBarsHD()
y = src.ExtractY().ReduceBy2()
u = src.ExtractU().ReduceBy2()
v = src.ExtractV().ReduceBy2()
CombinePlanes(y, u, v, planes="YUV", source_planes="YYY", sample_clip=src)

Throws an error: "CombinePlanes: source and target plane dimensions are different" although the colorspace is compatible.

Currently sample_clip is documented as "If supplied, output pixel_type will match that of sample_clip." so it should not care about the dimensions, only the colorspace, if compatible.

@pinterf
Copy link

pinterf commented Feb 2, 2023

The documentation is not perfect. The exact dimensions must match. Checking 4:4:4 would be easy, but let's take a YV12, then Avisynth would have to check that the passed chroma plane dimensions are proportionally O.K. for the given Y.
I guess sample_clip = src.ReduceBy2 would work in general.

@Reel-Deal
Copy link
Member Author

I'll have to clarify that in the documentation then. Speaking of that, I'll leave this open since I have a few questions for the documentation that I would be grateful if you expanded on some of the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants