Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Animation not really optimizing #1043

Open
abolog opened this issue Apr 2, 2022 · 3 comments
Open

Optimize Animation not really optimizing #1043

abolog opened this issue Apr 2, 2022 · 3 comments
Milestone

Comments

@abolog
Copy link

abolog commented Apr 2, 2022

I'm trying to export a simple animated mesh with few keyframes, but I noticed that the exporter bakes the keyframes for no obvious reason...?
Here's a screenshot, I'm using both linear and Bezier, but it kind of doesn't matter:
Untitled-1

The Optimized Export, does reduce few keyframes, but there are so many "useless" ones who do no change values.
Thanks

@pandaGaume
Copy link
Contributor

Thanks for the information.

we will have a look on it.
What i can say so far is we are only exporting animation as LINEAR and optimizations are computed On the fly with in house function from frame to frame, which is lead obviously to numerical precision error and wrong "optimization" decision.

Solution are

  • to tag the frame with the type of animation (from MAX/MAYA point of view) and take advantage of this information for optimization.
  • introduce some simple DSP algorithm but this is a non sense here
  • for GLTF take advantage of LINEAR, STEP, CUBICSPLINE interpolation mode.

regards

@abolog
Copy link
Author

abolog commented Apr 3, 2022

Ok thanks for looking into it, I thought I was doing something wrong.

But what do you mean to tag the frame with the type of animation used? I did set the keyframe to be linear, or you mean something else?

@pandaGaume

@pandaGaume
Copy link
Contributor

pandaGaume commented Apr 3, 2022

I'm mean taging the frame into the code, where we do not take the type of animation into account. The frames are processed as timeseries without knowledge of where the sampling is coming from (Linear, Bezier,..). This has the advantage to be generic but has border effect such the one you experienced.
related to #1021

@thomlucc thomlucc added this to the Future milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants