Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this pakcage need an interface? #42

Open
jakobnissen opened this issue Mar 12, 2021 · 2 comments
Open

Does this pakcage need an interface? #42

jakobnissen opened this issue Mar 12, 2021 · 2 comments

Comments

@jakobnissen
Copy link
Member

Suppose someone who studied modified RNAs want to work with this package. So they create a new BioSymbol type (and an Alphabet type for BioSequences work).

Does it make sense to have an interface with what is minimally expected to implement? I suppose one can get away with implementing very little.

@TransGirlCodes
Copy link
Member

TransGirlCodes commented Jul 15, 2021

Perhaps we define a BioSymbols interface as a set of unsigned values, that have all the basic operations, plus a trait defining whether the values are one-hot encoded, to conform with an interface around compatibility etc.

@jakobnissen
Copy link
Member Author

To facilitate fast IO, we probably also want to have some sort of ASCII shortcuts, i.e. being able to construct UInt8 from your BioSymbol effectively when they can be represented as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants