Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-alpha.0 crashes on node 0.10 #73

Open
scf2k opened this issue Aug 20, 2015 · 4 comments
Open

4.0.0-alpha.0 crashes on node 0.10 #73

scf2k opened this issue Aug 20, 2015 · 4 comments
Labels
Milestone

Comments

@scf2k
Copy link

scf2k commented Aug 20, 2015

blessc crashes on node 0.10 with error:

./.bin/blessc

fs-promise/node_modules/any-promise/any-promise.js:33
  throw new Error('Must install one of: '+libs.join());
        ^
Error: Must install one of: es6-promise,promise,native-promise-only,bluebird,rsvp,when,q

It will work if there is some of the listed libraries is installed in node scope.

@mtscout6
Copy link
Member

PR #74 should fix this.

@mtscout6 mtscout6 reopened this Aug 20, 2015
@mtscout6
Copy link
Member

Looks like our test runner was actually failing those tests but the error wasn't getting surfaced correctly fooling the CI into thinking that it passed.

Note the 0 exit code from Travis though you can see red 😢
screen shot 2015-08-20 at 10 45 02 am

I was hoping this would be a quick fix, but that does not appear to be the case. Thankfully the code coverage changes we made will surface this more quickly in the future.

@mtscout6 mtscout6 added this to the v4.0 milestone Sep 25, 2015
@petetrickey
Copy link

Following the update of 4.0.0 to release, this is now occuring for us. The error occurs when running any bless function. E.g. blessc -v

screen shot 2016-03-09 at 10 35 38

When we roll back to 3.0.3 the error is no longer present.

@mtscout6
Copy link
Member

I'm thinking Bless 4 will need to be on Node 4.0 and later. See #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants