Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticleFeedbackv5 not responsive #299

Closed
NovaFlare opened this issue Jun 25, 2014 · 9 comments
Closed

ArticleFeedbackv5 not responsive #299

NovaFlare opened this issue Jun 25, 2014 · 9 comments

Comments

@NovaFlare
Copy link

From http://en.brickimedia.org/wiki/Forum:Article_feedback_not_working_on_mobile :

"The article feedback feature isn't working on mobile. It loads for a few seconds, but then it shows the page as empty. Any known reasons as to why?"

@georgebarnick georgebarnick added this to the Q3 2014 milestone Jun 26, 2014
@seaside98
Copy link
Member

It isn't set up to shrink down to the correct size, so we hide it.

Edit

NVM. Wrong thing.

@Edward-Nigma
Copy link

Well, when it does load, it looks fine... So it shouldn't be hidden. (I had to take the screenshot before the text fully loaded, so the title and sidebar text isn't visible)
screenshot_2014-06-07-21-50-35

@georgebarnick
Copy link
Member

As you're screenshot points out, it works okay on your tablet, but the problem is that tablet PPI and screen resolutions vary, so there's no way to be sure if it will work decently on all tablets. It works decently on my phone's landscape orientation, but works poorly on its portrait orientation.

cgrjnkj
nybxqpl

Device: LGE Nexus 5
Operating system: Android L
Browser: Chrome 36.0.1985.65

@seaside98
Copy link
Member

Does the right side have to be a fixed width? I feel like a lot of Brickimedia preforms poorly on mobile. We haven't really adjusted any plugins work and/or look good on mobile. The best solution would probably be to have something like this instead:
mobile feedback

@Edward-Nigma
Copy link

Oh, I forgot to mention: I don't actually know if this is a bug or not, but portrait mode on mobile loads the mobile skin while landscape shows the desktop skin. It's only happened to me on this device, on my old phone it hasn't. I'll provide some system details in case that has anything to do with it. The images not loading is a problem with my device, which will take extremely long times loading just a single image on Chrome.

screenshot_2014-06-27-13-15-10

Device: Samsung Galaxy Tab III
OS: Android 4.2.2
Browser: Chrome 34.0.1847.114

@Edward-Nigma
Copy link

Here's the portrait orientation as well, which I couldn't upload for reasons unknown.

screenshot_2014-06-27-13-15-10

@georgebarnick
Copy link
Member

That has to do with the width of the landscape mode of that tablet, which
apparently is over the threshold width of the mobile/tablet skin. If we
increase that threshold we risk having some desktop users ending up with
the mobile/tablet skin.

@Edward-Nigma
Copy link

Ah, okay. I should just try using portrait orientation for reading/editing articles.

@georgebarnick georgebarnick modified the milestones: Q4 2014, Q3 2014 Dec 20, 2014
@georgebarnick georgebarnick modified the milestones: Q1 2015, Q4 2014 Jan 1, 2015
@georgebarnick georgebarnick modified the milestones: Q2 2015, Q1 2015 Apr 9, 2015
@neoncitylights neoncitylights changed the title Article feedback not working on mobile ArticleFeedbackv5 not responsive Feb 6, 2016
@neoncitylights neoncitylights modified the milestones: Q2 2016, Q2 2015 Feb 6, 2016
@neoncitylights
Copy link
Contributor

Superseded by https://phabricator.wikimedia.org/T34293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants