Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolidJS: mitosis compiles the attribute "for" to "htmlFor" #1319

Open
1 of 12 tasks
kauderk opened this issue Dec 15, 2023 · 2 comments · May be fixed by #1369
Open
1 of 12 tasks

SolidJS: mitosis compiles the attribute "for" to "htmlFor" #1319

kauderk opened this issue Dec 15, 2023 · 2 comments · May be fixed by #1369
Labels
bug Something isn't working

Comments

@kauderk
Copy link

kauderk commented Dec 15, 2023

I am interested in helping provide a fix!

Yes

Which generators are impacted?

  • All
  • Angular
  • HTML
  • Preact
  • Qwik
  • React
  • React-Native
  • Solid
  • Stencil
  • Svelte
  • Vue
  • Web components

Reproduction case

https://mitosis.builder.io/?outputTab=M4ewNglgJkA%3D&code=KYDwDg9gTgLgBAE2AMwIYFcA29noHYDGMAlhHnALICeAwhALaR7B4wAUYUEYAzgFxwA3nGIIBPGFGJ4A5nAC%2BASiEAoOHCjAY6KOQA8mVACNgmOMmgBeQQHJDJzDfkA%2BW%2FdNO9AeneZnAbhV5FSA

Expected Behaviour

the "for" attribute shouldn't compile to "htmlFor"

Actual Behaviour

I know it's a small issue but I guess mitosis has to adapt to all the frameworks changes
https://github.com/solidjs/solid/releases/tag/v1.4.0#:~:text=className%2C%20htmlFor%20deprecated

Additional Information

Maybe mitosis should accept version targets
@kauderk kauderk added the bug Something isn't working label Dec 15, 2023
@samijaber
Copy link
Contributor

Just gotta remove this mapping!

mitosis/packages/core/src/generators/solid/blocks.ts

Line 13 in e862056

for: 'htmlFor',

@JerryWu1234
Copy link
Contributor

let me try this

@JerryWu1234 JerryWu1234 linked a pull request Feb 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 1319 about the solid remove a property JerryWu1234/mitosis
3 participants
@samijaber @JerryWu1234 @kauderk