feat[Angular]: Allow passing explicit selectors #1443
Conversation
|
|
~~I'm having some issues running the snapupdates. ~~
SOLUTION: Manually ran |
seofernando25
changed the title
seofernando25
changed the title
| selector: `'${kebabCase(json.name || 'my-component')}, ${json.name}'`, | ||
| selector: options.selector | ||
| ? `'${options.selector}'` | ||
| : `'${kebabCase(json.name || 'my-component')}, ${json.name}'`, |
There was a problem hiding this comment.
I would suggest to remove the ${json.name} as default.
If a users wants to overwrite the selector with non kebabCase they may use options.selector.
Description
Adds an explicit,
selectoroption, allowing to override the default,selector: `'${kebabCase(json.name || 'my-component')}, ${json.name}'`This doesn't quite work if you have more than one component per project since all of them would have the same name
Another option could try is to keep as is and leave the warning there.
Closes #1442
Also see: angular's style guide
Relevant PR that added it in the first place
EDIT: Ok I think I can see why it was added there in the first place... might be wise to allow overriding the
selector