Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomial: Add overload which is only documented #8189

Merged
merged 1 commit into from May 17, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented May 6, 2024

Summary of Changes

Add code (a 3-liner) for a documented utility function. I did not add it to the testsuite as I have no idea for the parameter.

Release Management

@afabri
Copy link
Member Author

afabri commented May 6, 2024

@stla, could you please cherry-pick and use it to check.

@stla
Copy link

stla commented May 8, 2024

@stla, could you please cherry-pick and use it to check.

I have to download CGAL 6 in order to check a problem with RcppCGAL. But how can I "cherry-pick" your commit?

@sloriot
Copy link
Member

sloriot commented May 15, 2024

Successfully tested in CGAL-6.0-Ic-242

@lrineau lrineau self-assigned this May 16, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 16, 2024
@lrineau lrineau merged commit 860a780 into CGAL:master May 17, 2024
8 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 17, 2024
@lrineau lrineau deleted the Polynomial-fix_8182-GF branch May 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No function square_free_factorize 1/2
4 participants