Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document issue about generalized map's insert 2-cell in 3-cell #8195

Closed
eiiijiiiy opened this issue May 9, 2024 · 3 comments · Fixed by #8199
Closed

Document issue about generalized map's insert 2-cell in 3-cell #8195

eiiijiiiy opened this issue May 9, 2024 · 3 comments · Fixed by #8199

Comments

@eiiijiiiy
Copy link

eiiijiiiy commented May 9, 2024

The example of inserting a 2-cell in a 3 cell given in the user manual of Package Generalized Maps lists the inserted 2-cell as std::vector{dh1, ..., dh8}, as shown in the figure below. However, if I understand it correctly, the implementation of is_insertable_cell_2_in_cell_3 and the other example of gm operations indicate it should be std::vector{dh1, dh3, dh5, dh7} instead of the full loop from dh1 to dh8. The latter actually fails the assertion of is_insertable_cell_2_in_cell_3.
image

@gdamiand
Copy link
Member

Thanks for the issue: this is indeed a bug in the doc. Fixed in #8199.

@lrineau
Copy link
Member

lrineau commented May 17, 2024

@eiiijiiiy Thanks. That is now merged and fixed in CGAL master branch. PR #8199

@eiiijiiiy
Copy link
Author

thanks all!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants