Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native PostgreSQL result as expected result in AbstractWireProtocolTypeTest #363

Closed
AShiou opened this issue Jul 20, 2023 · 1 comment

Comments

@AShiou
Copy link
Contributor

AShiou commented Jul 20, 2023

In AbstractWireProtocolTypeTest, we aim to test that the Wire Protocol type result is the same as the PostgreSQL type result. Therefore, there is no need to manually write the expected result. Instead, we should assert whether the Wire Protocol type result matches the PostgreSQL type result.

Possible Solution

To achieve this, we can modify the execute function in AbstractWireProtocolTypeTest to execute the same SQL query separately using PostgreSQL and the Wire Protocol, and then compare the query results.

@goldmedal
Copy link
Collaborator

legacy issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants