Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Option to remove UUID in the images #42

Open
tedgonzalez opened this issue Feb 8, 2020 · 6 comments
Open

[feature request] Option to remove UUID in the images #42

tedgonzalez opened this issue Feb 8, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tedgonzalez
Copy link

Describe
Hi thanks for the awesome tool! I'm just wondering if there's an easy way to remove the UUID from the image filenames?

Desktop (please complete the following information):

  • OS: 10.14.6
  • xcparse Version 2.1.0
  • Swift version 5.1.3
@tedgonzalez tedgonzalez added the bug Something isn't working label Feb 8, 2020
@abotkin-cpi abotkin-cpi added enhancement New feature or request and removed bug Something isn't working labels Feb 8, 2020
@abotkin-cpi
Copy link
Collaborator

Not via xcparse right now. The screenshot file names do follow a standard format so it should be possible to remove the UUIDs from the names (right now we just take the name of the attachment in the xcresult and output as that name which includes the UUID).

It’s a feature we should probably do and allow for some customization of attachment names like I mentioned here. Likely won’t get to this for another 2 weeks as engulfed in another project, so if someone wants to take a crack, feel free to comment here.

@tedgonzalez tedgonzalez changed the title [question/feature request] Option to remove UUID in the images [feature request] Option to remove UUID in the images Feb 10, 2020
@abotkin-cpi abotkin-cpi self-assigned this Feb 28, 2020
@abotkin-cpi abotkin-cpi added this to the 2.3 milestone Feb 28, 2020
@twink1e
Copy link

twink1e commented Jun 28, 2020

I also find the UUID a bit unwieldy.
How about renaming the screenshots to reflect the test name that it comes from? It will be easier to debug and track.
e.g. {class_name}{method_name}{idx}.{file_type}

If it sounds good I can take up the task

@AbhayVarshney
Copy link

AbhayVarshney commented Jul 21, 2020

@abotkin-cpi this is really great. Is there a timeline for the suggestion in the PR for adding flag "--ordered" so we know which screenshots were taken first?

@abotkin-cpi
Copy link
Collaborator

I'm looking to bring the ordered into xcparse in the next week or so.

With the file naming, I want to make an extensible format string so folks can pick what they want in there rather than hard-defining it & ensure we handle the 255 character limit for filenames & de-duplication resolution. That's likely tied to a major release before iOS 14 launch.

@ryanpato
Copy link

Hey @abotkin-cpi, is the work for ordered still ongoing? Really interested in this one!

@abotkin-cpi
Copy link
Collaborator

We've been a bit distracted recently, but expect to have this rolled up by end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants