Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module loading not working with Forge's ModList #449

Open
dscalzi opened this issue Sep 5, 2020 · 1 comment
Open

Module loading not working with Forge's ModList #449

dscalzi opened this issue Sep 5, 2020 · 1 comment

Comments

@dscalzi
Copy link

dscalzi commented Sep 5, 2020

Passing mods (modules) as mods to forge's --modListFile are not being picked up by Charset's module loader. Support should be added and backported to any supported versions.

See: https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/fml/relauncher/libraries/ModList.java

cc @TheFlash787

@asiekierka
Copy link
Member

That... explains quite a lot, actually. However, I am already using the ASMDataTable to query the list of loaded modules, which should be processing every mod loaded. Unless I'm doing the lookup too early, that is - I haven't looked into the modlist functionality very much, admittedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants