Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative potion fluid name string #461

Open
Primitive-Human opened this issue Dec 4, 2022 · 3 comments
Open

More informative potion fluid name string #461

Primitive-Human opened this issue Dec 4, 2022 · 3 comments

Comments

@Primitive-Human
Copy link

Primitive-Human commented Dec 4, 2022

Once a potion fluid is put in any fluid container except a glass bottle, the potion name and strength is not shown. Unless you've memorized all potions by their colors, you need to take a sample to find out which potion it was.

Other mods like IE already did something for their potion fluids where the potion effect and strength are appended in the fluid name. Could you do something similar?

https://github.com/BluSunrize/ImmersiveEngineering/blob/1.11.2/src/main/java/blusunrize/immersiveengineering/common/util/IEFluid.java

@Primitive-Human
Copy link
Author

Primitive-Human commented Dec 11, 2022

On second thought, I'll create custom fluid dye and fluid potions which I'll brew with another mod's barrel, and handle the filling/emptying using methods such as the ender io tank.

@asiekierka
Copy link
Member

Nuh-uh. Just because the feature request no longer bothers you personally, doesn't mean it's not a valid feature request.

@asiekierka
Copy link
Member

As I said back in February, Charset sees little to no maintenance - but the issues serve as a bug/feature request record for any potential future maintainers who might want to pick up the project, as well as any contributors passing by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants