Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up User Contributed Notes for code reference #13

Open
viktorix opened this issue Aug 3, 2022 · 5 comments
Open

Set up User Contributed Notes for code reference #13

viktorix opened this issue Aug 3, 2022 · 5 comments

Comments

@viktorix
Copy link
Member

viktorix commented Aug 3, 2022

Set up "User Contributed Notes" for code reference using comments.

  • Moderated and approved before being published.
  • Need to ensure code highlighting works.
@joyously
Copy link

joyously commented Aug 3, 2022

Yesterday's WP docs meeting had a thread about moderating the comments.

Jb Audras
9:31 AM
Quick open floor question: is there anyone else than the people listed here that is also currently curating Devhub User contributed notes?That’s not a problem (at all!), but I have a few recommendation on how I’m handling them since one year or two 🙂
I see plenty of comments approved that would not have been approved that quickly as per the previous (but not documented, sigh) workflow. Some of them are not very relevant (like classic “thank you messages”). Most importantly, some of them need to be addressed on Trac (docblock errors). In this case, I never publish the comment but I rather open a Trac ticket and mention the commenter for proper Core Props attribution.

He said he would draft up some bullet points on moderating the comments.

@viktorix
Copy link
Member Author

viktorix commented Aug 3, 2022

Thanks for sharing. Let's keep an eye on that. If you see the draft of bullet points, then do post it here. I think the common sense in this situation should suffice:

  • if it doesn't explain anything or add additional information/code, then it shouldn't be posted
  • issues/errors should be opened in the appropriate place, core repo or docs issue tracker for issues with the notes
  • no external (non-CP) links unless it's in the code snippet using public CDN for assets (JS/CSS) or a link to a ClassicPress's GitHub issue/PR
  • Code snippets should be functional and not cause an error/warning/notices
  • Reviewer can request second review if not sure

I think we should also create a "ClassicPress Bot" account which we can use to copy explanations/code snippets from WP's code reference and include proper attribution to the original user.

@joyously
Copy link

joyously commented Aug 3, 2022

I think we should also create a "ClassicPress Bot" account

The ones that were copied from the codex have "Codex" as the account. The attribution is a bit muddy there, but copying code from WP Code Ref is covered by the GPL part of the licensing, so it could say "Codex" also.

The WP docs team has a guy that is starting to go through all the code examples with the coding standard. I think that's a bit much and would rather see them tested to be sure they do what is intended. (But most are pretty simple.)

@viktorix
Copy link
Member Author

viktorix commented Aug 4, 2022

It looks like UCN are already built-in, just not implemented in the frontend:
image

This makes implementation easier.

@viktorix
Copy link
Member Author

viktorix commented Aug 4, 2022

Adding one more note about the process user would have to go through to leave a note:

  1. This would not be public. The user would have to be registered with a subscriber role.
  2. We have integration between Discourse and docs site where members of specific groups in the forum are created (and used for SSO) in the docs site. Right now, those groups are admins and authors. Groups are private. I'm thinking of creating a group for subscribers and making it public, so any forum user could join the group and become a registered subscriber on the docs site.
  3. Once they log in to docs site using Discourse SSO, they will have a comment form to leave a note.
  4. Notes will be moderated and reviewed before publishing.

This process will ensure there's no spam. We will provide instructions/guidelines for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants