83 project set up scripts arent os agnostic #96
Conversation
|
|
||
| ``` | ||
| sudo mongod --dbpath ~/data/db | ||
| mongosh mongodb://localhost:27017/pa-wildflower-selector |
There was a problem hiding this comment.
This doesn't run an instance of mongodb, you already did that by setting it up to "install mongod as a service." This opens the mongo shell, which is nice but not required for anything we do below I think. You could just say "for Windows, this happened automatically when you installed mongod as a service."
| @@ -0,0 +1,98 @@ | |||
| const https = require('https'); | |||
There was a problem hiding this comment.
This is impressive, but you're working way harder than you have to here by using promise chains (calling then() and catch() functions in chains etc). Using promise constructors and chains is not necessary anymore. You should switch this up to use async/await so your code can read as a simple linear series of steps. It's a lot easier to maintain.
There's a pretty good tutorial here:
|
This isn't needed since git shell works on windows. |
I added "npm run restore-test-data-win" as "npm run restore-test-data" did not run in Windows.
"npm run restore-test-data-win" is os agnostic as it relies on a js script. This is tested on my windows machine.
This pull request is for the js script, package.json reference, and readme update.
Evidence of this running locally:
