Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tooltip library is causing app.spec.js to fail #167

Open
timwis opened this issue Oct 12, 2017 · 3 comments
Open

New tooltip library is causing app.spec.js to fail #167

timwis opened this issue Oct 12, 2017 · 3 comments
Labels
bug v2
Milestone
Hand-off

Comments

@timwis
Copy link
Member

timwis commented Oct 12, 2017

Not sure how it could happen but it appears to be babel/esmodules related. The error is Unexpected token export on dist/popper-utils.js:1002 :-(
@timwis timwis added this to the Hand-off milestone Oct 12, 2017
@timwis
Copy link
Member Author

timwis commented Oct 14, 2017

Fix is pending merge of hekigan/vue-directive-tooltip#20

@timwis
Copy link
Member Author

timwis commented Oct 16, 2017

Merged, just waiting on it to be published to npm.

timwis added a commit that referenced this issue Oct 17, 2017
@timwis
Skip app.spec.js test per #167
4787c52
@timwis
Copy link
Member Author

timwis commented Oct 17, 2017

For now I've disabled the app.spec.js test via a line in package.json. Once the new version of vue-directive-tooltip is pushed to npm, we can uncomment that line to re-enable the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v2
Projects
None yet
Milestone
Hand-off
Development

No branches or pull requests
1 participant
@timwis