Also integrate the sphinx docs into the binaries/release/unstable folder output

[ibell]

I am not sure how best to handle this, but we should make sure that when we do a release, the docs are up to date with the release branch. Currently they always upload to public_html/binaries

[jowr]

I'll have a look - docs are always uploaded to Sphinx, only the release script pushes a zip files to binaries...

[ibell]

Yes, always uploading to public_html/sphinx is the problem, but I'm not
sure how to fix this because we need to use something that is renderable.

On Fri, Jan 2, 2015 at 5:51 AM, Jorrit Wronski notifications@github.com
wrote:

I'll have a look - docs are always uploaded to Sphinx, only the release
script pushes a zip files to binaries...

—
Reply to this email directly or view it on GitHub
#378 (comment).

[jowr]

This is not done. The commit f635528 messed up the release script.

This line https://github.com/CoolProp/CoolProp/blob/master/dev/scripts/release.bsh#L106 refers to folderm that has been replaced by 'sphinx' and this one https://github.com/CoolProp/CoolProp/blob/master/dev/scripts/release.bsh#L118 expands to $BASEDIR/$BINFOLDER/sphinx/sphinx is that intended? Do we really want the sphinx files on sourceforge - http://sourceforge.net/projects/coolprop/files/CoolProp/5.0.6/sphinx ?

If you could explain the desired behaviour, I might be able to help 😉

[ibell]

Argh. Sorrry about that. The idea is that we also want the docs to be
built in the same way as the binaries, getting put into binaries/sphinx for
a build from master branch, or release/sphinx when built from release
branch. That way we can be 100% sure that the docs are also tagged to the
same revision as the binaries. Furthermore, I am now automatically forcing
a full rebuild of all binary builders as well as the docs if the branch is
release, so that should avoid old files ending up in sphinx docs.

$BASEDIR/$BINFOLDER/sphinx/sphinx should be $BASEDIR/$BINFOLDER/sphinx I
think

And no, I don't think we want the sphinx files on SF :)

Ian

On Tue, Jan 13, 2015 at 7:38 AM, Jorrit Wronski notifications@github.com
wrote:

This is not done. The commit f635528
f635528
messed up the release script.

This line
https://github.com/CoolProp/CoolProp/blob/master/dev/scripts/release.bsh#L106
refers to folderm that has been replaced by 'sphinx' and this one
https://github.com/CoolProp/CoolProp/blob/master/dev/scripts/release.bsh#L118
expands to $BASEDIR/$BINFOLDER/sphinx/sphinx is that intended? Do we
really want the sphinx files on sourceforge -
http://sourceforge.net/projects/coolprop/files/CoolProp/5.0.6/sphinx ?

If you could explain the desired behaviour, I might be able to help [image:
😉]

—
Reply to this email directly or view it on GitHub
#378 (comment).

[jowr]

OK, I'll have a look. Thanks.

[jowr]

I just committed some changes to the script. I could not test the upload of the docs without making a release, but the rest should work. Let us keep this issue around until the new script is fully tested.

[ibell]

Yes, sounds good. What was the problem with the docs when I released
v5.0.6? It looks ok to me from a cursory glance.

Ian

On Tue, Jan 13, 2015 at 9:58 AM, Jorrit Wronski notifications@github.com
wrote:

I just committed some changes to the script. I could not test the upload
of the docs without making a release, but the rest should work. Let us keep
this issue around until the new script is fully tested.

—
Reply to this email directly or view it on GitHub
#378 (comment).

[jowr]

The sphynx folder was on SourceForge and the zip file was not generated correctly.

[ibell]

Umm @jowr, are we safe to close this one after the 5.0.7 release? It looks good to me I think, there are the docs in a zip file, and no sphinx directory