Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabular] Warn about tabular folder size #43

Closed
ibell opened this issue May 28, 2014 · 11 comments
Closed

[Tabular] Warn about tabular folder size #43

ibell opened this issue May 28, 2014 · 11 comments
Milestone

Comments

@ibell
Copy link
Contributor

ibell commented May 28, 2014

No description provided.

@ibell
Copy link
Contributor Author

ibell commented May 28, 2014

Touch files on read

@jowr jowr added this to the v 5.1 milestone Feb 10, 2015
@jowr
Copy link
Member

jowr commented Feb 10, 2015

Maybe we should collect all issues in one place -> #262

@ibell
Copy link
Contributor Author

ibell commented Feb 10, 2015

I dunno, I think it is better to keep them as separate issues in general,
it is easier to link commits and issues if they are separate. We could tag
them with [TTSE] or something like that.

On Tue, Feb 10, 2015 at 1:58 AM, Jorrit Wronski notifications@github.com
wrote:

Maybe we should collect all issues in one place -> #262
#262


Reply to this email directly or view it on GitHub
#43 (comment).

@ibell ibell changed the title Warn about TTSE folder size [TTSE] Warn about TTSE folder size Feb 23, 2015
@ibell
Copy link
Contributor Author

ibell commented Feb 23, 2015

@jowr - Any thoughts on how best to implement this one? It's about time. Looks like it will be pretty easy to use zlib to compress the table files to about 30% of their original sizes, so that will reduce the pressure quite a bit.

That said, it looks like if you build all fluids (p-h and p-T), and its about 20 MB/fluid, you are looking at 2.24 GB, which is quite a lot. And that's not even considering mixtures. Perhaps we error out if there are more than 1 GB of tables? Or something like that? And add a configuration key that you can set to over-ride this behavior?

@jowr
Copy link
Member

jowr commented Feb 23, 2015

Sounds reasonable, but would that involve a check of the folder size each time you run CoolProp? We might not be able to get around that... I also noticed that @LeonardoPierobon had quite some issues with the old tables. I hope he shares his experience with us in written form soon... The essence is that we had to increase to matrix size to 300x300 because there were many cases with a faulty evaluation of transport properties. Since most of them were close to the two-phase domain, a robust check for that might as well do the job.

  • Are we sure 200x200 is enough?
  • zlib sounds like a good idea in any case
  • What about a 2-step procedure? Issue warning at a folder size above 1GB and error out above 1.5GB - both numbers should be configurable. People that want to disable the warnings should just set a high value, no extra key to disable the check.

@ibell
Copy link
Contributor Author

ibell commented Feb 23, 2015

@jowr - I think configuration keys can be used to set the TTSE table size, we just need to be sure that we document this clearly. Default can stay at 200x200, and we can increase as needed. Changing the size causes a rebuild of the tables.

For zlib, plan is to use miniz (https://code.google.com/p/miniz/)

Sounds like a plan in terms of warnings/errors. That is pretty much what I had in mind. Now just need to figure out how to do cross-platform directory size in c++. Something like du, but in C++ and that works on windows and linux. Any ideas?

@jowr
Copy link
Member

jowr commented Feb 23, 2015

How about this one? http://www.cplusplus.com/forum/beginner/107265/

@jowr
Copy link
Member

jowr commented Feb 23, 2015

We conclude: Boost or command line call (http://stackoverflow.com/a/15497931)

@ibell
Copy link
Contributor Author

ibell commented Feb 23, 2015

boost = command line = :(

Overall command line is less :( I think. The dependencies for boost just
to do this are rather large. What about poco?

On Mon, Feb 23, 2015 at 9:02 AM, Jorrit Wronski notifications@github.com
wrote:

We conclude: Boost or command line call (
http://stackoverflow.com/a/15497931)


Reply to this email directly or view it on GitHub
#43 (comment).

@ibell
Copy link
Contributor Author

ibell commented Feb 24, 2015

In the end, two painful recursive solutions, I think linux wins out this time.

@ibell
Copy link
Contributor Author

ibell commented Feb 24, 2015

See #496

@ibell ibell changed the title [TTSE] Warn about TTSE folder size [Tabular] Warn about tabular folder size Mar 2, 2015
@ibell ibell closed this as completed in ceef2cd Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants