Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving acentric factor through Props1SI fails #448

Closed
DanWBR opened this issue Feb 3, 2015 · 4 comments
Closed

Retrieving acentric factor through Props1SI fails #448

DanWBR opened this issue Feb 3, 2015 · 4 comments
Milestone

Comments

@DanWBR
Copy link

DanWBR commented Feb 3, 2015

Using C# interface, calling Props1SI("1-Butene", "accentric") fails with an invalid identifier exception.

This is on v5.0.6, it was working fine on v4.

By the way, shouldn't it be called "acentric", with only one "c"? Also tried that and it failed. I've searched the documentation but didn't find anything helpful (a list of valid properties, for instance).

@ibell
Copy link
Contributor

ibell commented Feb 3, 2015

How about this:
http://www.coolprop.org/coolprop/HighLevelAPI.html#table-of-string-inputs-to-propssi-function
?

And yes, seems accentric is missing for some reason. I'll fix it.

And yes, it seems you are right about the spelling :) Oops.

On Tue, Feb 3, 2015 at 5:04 PM, Daniel Medeiros notifications@github.com
wrote:

Using C# interface, calling Props1SI("1-Butene", "accentric") fails with
an invalid identifier exception.

This is on v5.0.6, it was working fine on v4.

By the way, shouldn't it be called "acentric", with only one "c"? Also
tried that and it failed. I've searched the documentation but didn't find
anything helpful (a list of valid properties, for instance).


Reply to this email directly or view it on GitHub
#448.

@DanWBR
Copy link
Author

DanWBR commented Feb 3, 2015

Hi Ian,

I found that table, but it contains the parameter list for PropsSI, not Props1SI...

I'll wait for the fix then. I'm currently updating the calls in DWSIM to use v5 and found this bug during initialization of the compound database.

Thanks!

@ibell
Copy link
Contributor

ibell commented Feb 3, 2015

Ah right, the possible inputs to Props1SI are the trivial inputs, those
that don't require any information about the state. I'm fixing the
acentric bug right now.

If you are are using Csharp, you might want to consider using the abstract
state classes added in v5. It's much faster!

Ian

On Tue, Feb 3, 2015 at 5:14 PM, Daniel Medeiros notifications@github.com
wrote:

Hi Ian,

I found that table, but it contains the parameter list for PropsSI, not
Props1SI...

I'll wait for the fix then. I'm currently updating the calls in DWSIM to
use v5 and found this bug during initialization of the compound database.

Thanks!


Reply to this email directly or view it on GitHub
#448 (comment).

@ibell ibell closed this as completed in 183868d Feb 3, 2015
@ibell ibell added this to the v5.0.7 milestone Feb 3, 2015
@ibell
Copy link
Contributor

ibell commented Feb 3, 2015

This one is fixed, if there are others let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants