Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoolPropDbl #495

Merged
merged 1 commit into from Feb 24, 2015
Merged

CoolPropDbl #495

merged 1 commit into from Feb 24, 2015

Conversation

mikekaganski
Copy link
Contributor

Introduce CoolPropDbl to replace long doubles. This may help to overcome
possible portability problems, and test for efficiency and precision.

Introduce CoolPropDbl to replace long doubles. This may help to overcome
possible portability problems, and test for efficiency and precision.
@mikekaganski mikekaganski mentioned this pull request Feb 24, 2015
ibell added a commit that referenced this pull request Feb 24, 2015
@ibell ibell merged commit 703fd30 into CoolProp:longdouble_remap Feb 24, 2015
@ibell
Copy link
Contributor

ibell commented Feb 24, 2015

Ok, let's see how the testing looks. I'm quite curious. And then we can add a preprocessor macro that allows you to disable the mapping

@mikekaganski
Copy link
Contributor Author

Unfortunately, I cannot test it (I mean both performance and precision) - I only have MS VC++ under Win7x64, and there long double == double.

@mikekaganski mikekaganski deleted the CoolPropDbl branch February 24, 2015 06:33
@ibell
Copy link
Contributor

ibell commented Feb 24, 2015

Right, thats where our buildbot network is useful:
http://www.coolprop.dreamhosters.com:8010/

On Mon, Feb 23, 2015 at 11:32 PM, mikekaganski notifications@github.com
wrote:

Unfortunately, I cannot test it (I mean both performance and precision) -
I only have MS VC++ under Win7x64, and there long double == double.


Reply to this email directly or view it on GitHub
#495 (comment).

@ibell
Copy link
Contributor

ibell commented Feb 24, 2015

I just fired off all the builders on that branch, let's see what the
results are - you can see it in the grid

On Mon, Feb 23, 2015 at 11:33 PM, Ian Bell ian.h.bell@gmail.com wrote:

Right, thats where our buildbot network is useful:
http://www.coolprop.dreamhosters.com:8010/

On Mon, Feb 23, 2015 at 11:32 PM, mikekaganski notifications@github.com
wrote:

Unfortunately, I cannot test it (I mean both performance and precision) -
I only have MS VC++ under Win7x64, and there long double == double.


Reply to this email directly or view it on GitHub
#495 (comment).

@ibell ibell modified the milestone: v5.0.8 Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants