Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory size calculations #500

Merged
merged 1 commit into from Feb 25, 2015
Merged

Fix directory size calculations #500

merged 1 commit into from Feb 25, 2015

Conversation

mikekaganski
Copy link
Contributor

No description provided.

@ibell ibell added this to the v5.0.8 milestone Feb 25, 2015
@@ -17,7 +17,7 @@
#include <stdint.h>
#include <iostream>

static double ftw_summer; // An evil global variable for the ftw function
static thread_local unsigned long long ftw_summer; // An evil global variable for the ftw function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 If you notice other things that are not thread-safe, PLEASE fix them. Thread safeness is something I am only aware of in a limited fashion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to revert this thread_local change since a lot of our compilers (VS2008 especially) don't support C++11 unfortunately.

ibell added a commit that referenced this pull request Feb 25, 2015
Fix directory size calculations
@ibell ibell merged commit e4672f1 into CoolProp:master Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants