Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill off the CRT deprecate warning (#512) #515

Merged
merged 1 commit into from Mar 1, 2015
Merged

Kill off the CRT deprecate warning (#512) #515

merged 1 commit into from Mar 1, 2015

Conversation

mikekaganski
Copy link
Contributor

No description provided.

@ibell
Copy link
Contributor

ibell commented Mar 1, 2015

Two comments:

This should only be applied if it is windows and the compiler is MSVC (#if defined _MSC_VER)

For some reason that I don't understand, setting #define _CRT_SECURE_NO_WARNINGS didn't silence this warning

ibell added a commit that referenced this pull request Mar 1, 2015
Kill off the CRT deprecate warning (#512)
@ibell ibell merged commit 07fa830 into CoolProp:master Mar 1, 2015
@mikekaganski
Copy link
Contributor Author

I suppose that you defined it (_CRT_SECURE_NO_WARNINGS) in place. It should be defined before header that declares the function, maybe at project level, and will silence out all such warnings, in all other possible cases, which may be undesirable

@ibell ibell modified the milestone: v 5.1 Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants