New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsFluidType function #552
Comments
Hi, I guess it can be done without re-implementing IsFluidType. Correct me if I'm wrong. |
Yes, but it doesn't separate pure and pseudo-pure fluids On Mon, Mar 23, 2015 at 10:39 PM, Ammar Bahman notifications@github.com
|
See https://github.com/ibell/coolprop/blob/c67ecc570e545d624c18feaf2a01e48b63ae1501/CoolProp/CoolProp.cpp#L446 and convert to CP v5 style |
It has the same style as before. Thank you |
That, in fact, is the old code :) On Fri, Mar 27, 2015 at 12:38 AM, Ammar Bahman notifications@github.com
|
Ok, new idea. I think it makes more sense to implement the function in ACHP, so what I propose is that I add an output to get_fluid_param_string that returns "true" if it is a pure fluid, or "false" if it is a pseudo-pure fluid. Now that you pretty much have to provide the backend in v5, that simplifies determination of the fluid type. |
Ok, now that you can differentiate between pure and pseudo-pure fluids with the HEOS backend, I think you have all you need to re-implement the functionality of IsFluidType in ACHP. In the end, I like this solution better than writing a hacky fix in CoolProp. |
Hi,
I'm working on ACHP model with CoolProp 5.x, and IsFluidType function is intensively used in the model. If there is no alternative, could you please re-implement the function ?
Thank you
The text was updated successfully, but these errors were encountered: