Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for extension: table of quantities in the documentation for HAPropsSI like for PropsSI #591

Closed
postmath opened this issue Apr 15, 2015 · 5 comments
Milestone

Comments

@postmath
Copy link
Contributor

It looks like both input and output quantities are routed through Name2Type in the HumidAirProp.cpp file. The error message in that function also appears to be somewhat out of date -- the givens Hha, Sha, Vha, Cha, Y, V, C, Z are not listed (nor are their aliases).

@ibell
Copy link
Contributor

ibell commented Apr 15, 2015

Correct. Could you make me a complete list of what is missing?

On Wed, Apr 15, 2015 at 2:19 PM, postmath notifications@github.com wrote:

It looks like both input and output quantities are routed through
Name2Type in the HumidAirProp.cpp file. The error message in that
function also appears to be somewhat out of date -- the givens Hha, Sha,
Vha, Cha, Y, V, C, Z are not listed (nor are their aliases).


Reply to this email directly or view it on GitHub
#591.

@postmath
Copy link
Contributor Author

As far as I can see, there are 18 quantities that would be accepted: T, P, R, W, D, B, H, S, M, K, and the 8 quantities listed above. I think a table could have three or four columns: one to list all their aliases (once again lifted from Name2Type); one with the appropriate SI unit; one with a textual description; and maybe some form of info on what is appropriate for input or output, though I think (from reading the source, and from http://www.coolprop.org/fluid_properties/HumidAir.html) that the criteria are too complicated to capture easily in a table column.

@ibell
Copy link
Contributor

ibell commented Apr 16, 2015

Basically this one, right?:
http://www.coolprop.org/apidoc/CoolProp.CoolProp.html#CoolProp.CoolProp.HAPropsSI

On Thu, Apr 16, 2015 at 8:02 AM, postmath notifications@github.com wrote:

As far as I can see, there are 18 quantities that would be accepted: T, P,
R, W, D, B, H, S, M, K, and the 8 quantities listed above. I think a
table could have three or four columns: one to list all their aliases (once
again lifted from Name2Type); one with the appropriate SI unit; one with
a textual description; and maybe some form of info on what is appropriate
for input or output, though I think (from reading the source, and from
http://www.coolprop.org/fluid_properties/HumidAir.html) that the criteria
are too complicated to capture easily in a table column.


Reply to this email directly or view it on GitHub
#591 (comment).

@postmath
Copy link
Contributor Author

Ah, cool! Yes, that's the one. If we include the paragraph directly below the table, and additionally Sha, Y, and Z :)

Reading that page very strictly, it says that these are the valid strings for input. As I understand it, they're also exactly the set of valid strings for output; it might be good to add that explicitly.

@ibell ibell added this to the v 5.1 milestone Apr 17, 2015
@ibell ibell closed this as completed in 51ae6ba Apr 18, 2015
@postmath
Copy link
Contributor Author

Thanks, Ian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants