Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R wrapper #668

Closed
mihirparadkar opened this issue May 13, 2015 · 22 comments
Closed

R wrapper #668

mihirparadkar opened this issue May 13, 2015 · 22 comments
Milestone

Comments

@mihirparadkar
Copy link

Could an R wrapper be added? I don't know of any packages that even come close to the functionality of CoolProp and it'd be really useful to have in R, even if it's a simple set of ffi calls around the C++ shared library.

@ibell
Copy link
Contributor

ibell commented May 13, 2015

Yes, this would be very simple in linux, slightly less so in windows. I've
done similar for REFPROP, could do so for CoolProp.

On Tue, May 12, 2015 at 11:31 PM, mihirparadkar notifications@github.com
wrote:

Could an R wrapper be added? I don't know of any packages that even come
close to the functionality of CoolProp and it'd be really useful to have in
R, even if it's a simple set of ffi calls around the C++ shared library.


Reply to this email directly or view it on GitHub
#668.

@ibell
Copy link
Contributor

ibell commented May 14, 2015

Are you willing to do some testing? Let me know what version of R you use, what platform, etc.

@mihirparadkar
Copy link
Author

Yes, of course. I primarily use R 3.2.0 on 32-bit Ubuntu, but I also use R 3.1.3 on 64-bit Windows 7.

@ibell
Copy link
Contributor

ibell commented May 14, 2015

Hmm, I am not sure how important the version of R is in terms of cross-version compatibility, but I'll put some stuff together, should be a week or so.

@mihirparadkar
Copy link
Author

Thanks. Once I have what you put together and some basic instructions on how to install/import the library, I'll make sure to give my feedback.

@ibell ibell added this to the v5.1.1 milestone May 29, 2015
@AntonioCarrilloAndres
Copy link

Hello, I was searching for a CoolProp R wrapper and found this conversation. I think it will be great to have this wrapper. I use R on 64 bit windows 7. Thank you.

@ibell
Copy link
Contributor

ibell commented Jun 10, 2015

Yes it will be great, though I'm not sure when Ill have a chance to finish
it. Should only take a few hours once I sit down and get at it.

On Wed, Jun 10, 2015 at 7:00 AM, AntonioCarrilloAndres <
notifications@github.com> wrote:

Hello, I was searching for a CoolProp R wrapper and found this
conversation. I think it will be great to have this wrapper. I use R on 64
bit windows 7. Thank you.


Reply to this email directly or view it on GitHub
#668 (comment).

@AntonioCarrilloAndres
Copy link

I am sure that a lot of people will thank you if you manage to finish the R wrapper!

ibell added a commit that referenced this issue Jun 29, 2015
ibell added a commit that referenced this issue Jun 29, 2015
ibell added a commit that referenced this issue Jun 29, 2015
@ibell
Copy link
Contributor

ibell commented Jun 29, 2015

Ok, working on windows, and should basically be working on linux soon. One or two little bugs to resolve.

@ibell
Copy link
Contributor

ibell commented Jun 29, 2015

Weirdly, it seems to be working fine on windows, and I am running into a few bugs that I don't understand on linux and OSX. Usually it is the other way around.

@ibell
Copy link
Contributor

ibell commented Jul 1, 2015

Ready for some testing I think. Files are up at http://www.coolprop.dreamhosters.com:8010/binaries/R/ . Docs are ready but not building properly now. Download Example.R, CoolProp.R,and the shared library for your appropriate platform, place them all in the same directory. Run the example. On windows, even though it says Windows_32bit, it is actually 64bit.

@AntonioCarrilloAndres
Copy link

Thank you Ian, I will be happy to test on Win64 and give some feedback

@AntonioCarrilloAndres
Copy link

I have made a first test on Win64 and seems to be working fine! Now I will try to use it in some research. Thank you again Ian!

@ibell
Copy link
Contributor

ibell commented Jul 1, 2015

For curiosity, what version of R do you use? This R wrapper was compiled
with 3.2.1

On Wed, Jul 1, 2015 at 9:40 AM, AntonioCarrilloAndres <
notifications@github.com> wrote:

I have made a first test on Win64 and seems to be working fine! Now I will
try to use it in some research. Thank you again Ian!


Reply to this email directly or view it on GitHub
#668 (comment).

@mihirparadkar
Copy link
Author

Thanks Ian! I'm really excited to try this out but there's a slight problem.
I can test on 64-bit Ubuntu and I use R 3.2.0, but the CoolProp.R and example.R files are compressed in the links (newlines are removed). Is there anywhere else I can download the .R files?

@ibell
Copy link
Contributor

ibell commented Jul 1, 2015

If you right-click on the file and "Save As..." it should repair the line
endings. buildbot does something funny with text files in its server

On Wed, Jul 1, 2015 at 10:03 AM, mihirparadkar notifications@github.com
wrote:

Thanks Ian! I'm really excited to try this out but there's a slight
problem.
I can test on 64-bit Ubuntu and I use R 3.2.0, but the CoolProp.R and
example.R files are compressed in the links (newlines are removed). Is
there anywhere else I can download the .R files?


Reply to this email directly or view it on GitHub
#668 (comment).

@ibell
Copy link
Contributor

ibell commented Jul 1, 2015

Also, on linux you might need to rebuild it yourself. Linux is more
special about architecture of binary files. Instructions are here for now:
https://github.com/CoolProp/CoolProp/blob/master/Web/coolprop/wrappers/R/index.rst

On Wed, Jul 1, 2015 at 10:06 AM, Ian Bell ian.h.bell@gmail.com wrote:

If you right-click on the file and "Save As..." it should repair the line
endings. buildbot does something funny with text files in its server

On Wed, Jul 1, 2015 at 10:03 AM, mihirparadkar notifications@github.com
wrote:

Thanks Ian! I'm really excited to try this out but there's a slight
problem.
I can test on 64-bit Ubuntu and I use R 3.2.0, but the CoolProp.R and
example.R files are compressed in the links (newlines are removed). Is
there anywhere else I can download the .R files?


Reply to this email directly or view it on GitHub
#668 (comment).

@mihirparadkar
Copy link
Author

Thank you very much. Surprisingly, it seems to work without building it myself.

@AntonioCarrilloAndres
Copy link

Ian, I use R 2.15 (I am a bit outdated..)

@ibell
Copy link
Contributor

ibell commented Jul 1, 2015

wow... and it still works for you? That is great news.

On Wed, Jul 1, 2015 at 10:28 AM, AntonioCarrilloAndres <
notifications@github.com> wrote:

Ian, I use R 2.15 (I am a bit outdated..)


Reply to this email directly or view it on GitHub
#668 (comment).

@jowr
Copy link
Member

jowr commented Jul 1, 2015

If you have any problems with the files, please try to download the files using the webserver instead of the buldbot frontend: http://www.coolprop.dreamhosters.com/binaries/R/

@ibell
Copy link
Contributor

ibell commented Jul 6, 2015

Ok, tests run and pass on windows, linux and OSX. Finally closing this issue. Thanks for your patience. Please let us know if you run into any other issues of any kind.

@ibell ibell closed this as completed Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants