New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabular backends and phase specification #882
Comments
What inputs? That's not a bad idea, to make sure you get the right phase
|
Typically, I would use T,p inputs that are very close to saturation and then I impose the phase to tell CoolProp whether I want the results for gas or liquid. |
That makes sense to me. I can see that being useful.
|
So do I understand correctly that phase specification using AbstractState.specify_phase() is currently ignored for tabular calculations? It doesn't seem to make a difference for me either with QT or TP inputs. This feature would be very useful for me too, and could eliminate the need to fudge the pressure and temperature away from the saturation line to ensure that CoolProp calculates for a gas rather than a mixture (the "fudging" method is not especially reliable). |
Phase specification will never be needed or used for QT as that is always
|
This is a little bit complex to implement - I'll have to think about how to resolve the problem. Should be doable though. Should greatly improve the reliability near saturation. |
I've made progress in tabular_refactor branch. I merged update functions from TTSE and bicubic into the common backend. Now only have one location to update code. I'm about ready to merge it back in I think. PT in liquid phase at low temperatures is very difficult - we quickly run out of space to bump to lower temperature, might have to consider using TTSE down there. |
I have some time to look at this today and can do some testing. What do you mean by might have to consider using TTSE down there? instead of bicubic? |
It seems that in the wedge near triple point pressure and between minimum Does that make sense?
|
Yes it does, thanks for the clarification. I'll have a look at it. At a first glance, it looks like the PT-update with imposed phase is not finished is that correct? Did you push all your work? |
Sadly, yes, I pushed my work, but I put up a testing script : I haven't fixed the vapor side yet, but that is simple to handle. Same On Mon, Dec 7, 2015 at 2:32 AM, Jorrit Wronski notifications@github.com
|
I know that the tables can yields "wrong" results for inputs close to saturation. I tried to circumvent this by specifying the phase because I know the phase for all calls beforehand. Unfortunately, this does not seem to make a difference. This could be related to #739 and #656
Is that a correct observation? Do we have plans about implementing such functionality?
The text was updated successfully, but these errors were encountered: