New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabular calcs with mixtures often return Dew T< Bubble T using PQ input pair #921
Comments
NOTE: Until a few minutes ago, the data in the above table was incorrectly entered. It has been edited to correct the errors. |
Could this just be a result of the interaction parameters? Do CoolProp & REFPROP agree when you don't use tabular backends? What version of REFPROP do you use? Do you use a custom HMX.BNC file? |
Sorry forget my last comment - must be something with the interpolation, not the interaction parameters. Would be useful to just look at error in prediction of p for given T for these given fluids. So we can see where the problems start. Could do you that? Calculate dewpoint pressure for given dewpoint temperatures for these fluids? |
No problem. For bicubic, I ran this in a loop:
And similarly for Refprop:
The results were as below (again, I've ignored TTSE because results were identical to bicubic):
dP = abs(pSatVapBicubic - pSatVapRefprop) |
If it's relevant, I'm using Refprop 9.12, the version that you provided at the beginning of last week. |
I think I have mostly fixed these issues. Please confirm. It will never be perfect, but I think I made it much better. |
It looks like your work was very effective. All discrepancies have been fixed to within an accuracy of 0.045°C. Thank you! |
I've traced a number of issues back to this behavior of the tabular backend and have collected a bunch of cases to demonstrate it. The code is somewhat lengthy, so I will provide just an example and results.
I initialize arrays refrig and tSatVap with the first two columns below:
Then we step through, using tSatVap and refrig as inputs, changing the "BICUBIC&REFPROP" backend string to "REFPROP" for the nontabular calculation:
Once this loop is complete, we have the tSatLiq***** outputs in the third and fourth columns above. As we see, the bubble point temperatures are lower than the dew point temperatures as calculated by Refprop directly (as we would expect), but higher than the dew point temperatures as calculated by the tabular backend (I've sorted the results by decreasing dT, the disparity between the Refprop and tabular result). I calculated with the TTSE backend as well, but the results were identical to those returned using the bicubic backend.
Using: January 11th nightly build of 5.1.2, C#.
The text was updated successfully, but these errors were encountered: