Numerical methods

[jowr]

Splitting several issues from CoolProp/CoolProp#263.

What should be reimplemented:

• calc_transport
• enable_TTSE
• enable_BICUBIC
• extend_twophase (enable EXTTP)
• twophase_derivsmoothing_xend
• rho_smoothing_xend
• tabular two phase derivatives
• tabular two phase smoothed derivatives

... and make sure that there is a converter function to make it backwards compatible.

[jowr]

Please add more here if there is an option I forgot.

[JonWel]

For the twophase_derivsmoothing_xend, can we simply replace:

properties->ddhp = state->drhodh_constp_smoothed(twophase_derivsmoothing_xend);

With:

properties->ddhp = state->first_two_phase_deriv_splined(CoolProp::iDmass, CoolProp::iHmass, CoolProp::iP, twophase_derivsmoothing_xend);

That may be an easy solution to this parameter.

[jowr]

I recommend to start by implementing all options without content. Make the structure and fill in functionality later. This speeds up the process as we can start testing earlier. Please also consider uploading your code so I can help you with reviewing your changes.

[JonWel]

For the calc_transport option, this is just an 'if' that compute or not the two properties (so not a lot to change between CoolProp versions).
The value of the non computed parameters is correctly updated to 4.29497e+009 that should be equal to 0xffffffff that define NaN in the Include.h file.
I think the calc_transport is OK.

[JonWel]

Ian is working on the tabular backend to correct a bug. Once done we should be closer to working tables (difficult to know if there will be others one after).

The main remaining thing now is the EXTTP, I'll start this this afternoon.

[JonWel]

Ian has corrected the bug I spoke in the previous comment.
Now I see that surface tension is not (yet?) implemented in the tabular backend, do I make an if to only calculate it if there is no tabular backend or do we implement it in the tabular backend? (I've no idea about the amount of work needed).

[ibell]

We implement it in the tabular backend. Can you file an issue please?

On Sun, Aug 2, 2015 at 5:16 AM, JonWel notifications@github.com wrote:

Ian has corrected the bug I spoke in the previous comment.
Now I see that surface tension is not (yet?) implemented in the tabular
backend, do I make an if to only calculate it if there is no tabular
backend or do we implement it in the tabular backend? (I've no idea about
the amount of work needed).

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

[JonWel]

done: CoolProp/CoolProp#760

[JonWel]

calc_phase: CoolProp/CoolProp#763

[jowr]

Is this solved? All boxes are checked, but I am not sure whether we can close this issue... @JonWel ?

[JonWel]

@jowr I added the remaining element we need to solve in the list.
(it has already has two issues opened, so we can also just close this one and just solve the issues)

[jowr]

I guess that closing #16 also means that this one is finally done.