Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 should not rely on std::isalnum #356

Open
jpcima opened this issue Jan 4, 2022 · 0 comments
Open

Base64 should not rely on std::isalnum #356

jpcima opened this issue Jan 4, 2022 · 0 comments

Comments

@jpcima
Copy link
Collaborator

jpcima commented Jan 4, 2022

According to the man page of isalnum:

In some locales, there may be additional characters for which isalpha() is true—letters which are neither uppercase nor lowercase.

This means that the function might let through characters outside the base64 alphabet.

reference:

return (std::isalnum(c) || (c == '+') || (c == '/'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant