Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure recruiter files #6152

Open
polvanrijn opened this issue Feb 8, 2024 · 1 comment
Open

Restructure recruiter files #6152

polvanrijn opened this issue Feb 8, 2024 · 1 comment

Comments

@polvanrijn
Copy link
Collaborator

This issue proposes to convert structure of:

dallinger
|_ recruiters
|_ prolific
|_ mturk

To a more general and extendable structure, namely:

dallinger
|_ recruiters
   |_ prolific
       |_ __init__.py
       |_ recruiter.py
       |_ service.py
   |_ mturk
       |_ __init__.py
       |_ messages.py
       |_ qualifications.py
       |_ recruiter.py
       |_ service.py
   |_ __init__py
   |_ recruiter.py
   |_ redis.py
   |_ service.py

This abstraction assumes that most recruiters have a 'service' doing the API calls to the recruiter and the 'recruiter' itself implementing the recruitment logic. How granular this file structure needs to be is open for discussion. A file structure like this would also work:

dallinger
|_ recruiters
   |_ prolific.py
   |_ mturk.py
   |_ __init__py
   |_ recruiter.py
   |_ redis.py
   |_ service.py
@pmcharrison
Copy link
Collaborator

Maybe instead of dallinger.recruiters.recruiter we should just put dallinger/recruiters/recruiter.py into dallinger/recruiters/__init__.py and then we can say from dallinger.recruiters import XYZ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants