Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automated build for automatic releasing #6

Open
DanielTamkin opened this issue Dec 18, 2020 · 0 comments
Open

Implement automated build for automatic releasing #6

DanielTamkin opened this issue Dec 18, 2020 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@DanielTamkin
Copy link
Owner

DanielTamkin commented Dec 18, 2020

Origin

When attempting to use this action elsewhere, i realized my testcases were faulty; resulting in this action never actually working until the latest release of v1.0.4 where the build is directly accessible.

The fix

As a quick fix, I've directly included the build into the repo. This is not great, I'd rather the build only be distributed with each release. Will explore options. Additionally, implementing this hot-fix included an enviroment shift to running under straight nodejs12, instead of a docker container; shaving off nearly 20s of run-time(since no container was spun up).

Resources

@DanielTamkin DanielTamkin added bug Something isn't working enhancement New feature or request labels Dec 18, 2020
@DanielTamkin DanielTamkin self-assigned this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant