Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Council overhaul #97

Draft
wants to merge 18 commits into
base: development
Choose a base branch
from
Draft

Council overhaul #97

wants to merge 18 commits into from

Conversation

lxgr-linux
Copy link
Member

@lxgr-linux lxgr-linux commented Oct 30, 2022

This will add:

  • qCouncils query:
      message QueryQCouncilsRequest {
        CouncelingStatus status = 1;
        repeated string voters = 3;
        uint64 card = 4;
        string creator = 5;
        IgnoreCouncils ignore = 2;
      }
    
      message IgnoreCouncils {
        bool status = 1;
        bool card = 2;
      }
  • User containing info about the council they are in:
    Removed the councilStatus field and replaced it with councilParticipation which has a status, which is analog to old councilStatus and a council attribute, which holds the council the user is in.
  • Disable users from participating in councils for their own cards
  • Prevent cards from being submitted to council twice:
    Therefore added the inCouncil status to cards, which is set, when a card is in a council
  • Implement Add voting timelimit to council #110
  • Feedback from @Niko-Sn myself on the implemnetation in the frontend

@lxgr-linux lxgr-linux linked an issue Oct 30, 2022 that may be closed by this pull request
@lxgr-linux lxgr-linux self-assigned this Dec 18, 2022
@patrickwieth
Copy link
Member

check out #12

@lxgr-linux lxgr-linux linked an issue Jan 4, 2023 that may be closed by this pull request
1 task
@lxgr-linux
Copy link
Member Author

@patrickwieth how do we want to proceed with this? Regarding council design and #153.
Is the council design fixed and ready to implement further?

@patrickwieth
Copy link
Member

From the perspective of backend/cardchain the design is fixed and ready to go, yes.
I posted in the FeatureFlag thread

@lxgr-linux lxgr-linux changed the base branch from master to development October 15, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants