Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Handling a library like @types/three #366

Open
joshuaellis opened this issue Mar 3, 2021 · 3 comments
Open

[RFC] Handling a library like @types/three #366

joshuaellis opened this issue Mar 3, 2021 · 3 comments

Comments

@joshuaellis
Copy link

I'm in a bit of a pickle with the library @three/types. I can't self merge because I have an OTHER_FILES.txt file and it's not realistic for me to get tests for every file listed there.

We're doing a gradual move over, and any new files we add we ensure best we can to include a test but I don't have the time or manpower to do one massive migration. This results in my PRs for even minor changes to the library hanging in limbo for 6days+. With three being released every month no matter how hard we work we're constantly chasing 😬

Does anyone have any suggestions or ideas that could resolve this pain? I appreciate this is probably an outlier. I want to keep the library in DT because it's the defacto but the hindrance on minor updates is a real killer.

@Methuselah96
Copy link

Methuselah96 commented Mar 3, 2021

It looks like there is some consideration for JSON elements being removed from config files (including OTHER_FILES.txt) here if I'm reading the code correctly. Perhaps it's worth checking to see if that's working correctly? This is just from a brief glance at the code, so I could be missing the intent.

@Methuselah96
Copy link

Methuselah96 commented Mar 3, 2021

Actually, on second read, it might be returning on the line before that check since the expectedForm for OTHER_FILES.txt is an empty array. Perhaps we could enhance that area of code to allow for removed items from OTHER_FILES.txt? I can't tell for sure without taking a closer look at it.

@orta
Copy link
Contributor

orta commented Mar 16, 2021

I didn't really have much to add on top of methuselah's feedback - It seems reasonable that removing files from the other files should be OK, I think we're much more wary of additions in that file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants