Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“Ready to merge” doesn‘t work from owners? #403

Open
andrewbranch opened this issue May 12, 2021 · 1 comment
Open

“Ready to merge” doesn‘t work from owners? #403

andrewbranch opened this issue May 12, 2021 · 1 comment

Comments

@andrewbranch
Copy link
Member

DefinitelyTyped/DefinitelyTyped#52911
@elibarzilay
Copy link
Contributor

Strange. There is just one place in the code that (1) applies the Self Merge label, and the very next line (2) adds the OfferSelfMerge comment, and then (3) the move to Waiting for Author to Merge. It did 1+3, but didn't do 2 (and also didn't barf at the premature request to merge since the offer wasn't made).

So my best guess is either some temporary GH api failure, or some race condition. If it happens again, can you leave it in the bad state and ping me about it so I can debug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elibarzilay @andrewbranch