Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest generation works bad in 1.18.1 #2008

Open
5 tasks done
molor opened this issue Jan 13, 2022 · 7 comments
Open
5 tasks done

Forest generation works bad in 1.18.1 #2008

molor opened this issue Jan 13, 2022 · 7 comments
Labels
status:accepted Will be fixed / added to WorldEdit, eventually status:upstream This issue should be handled upstream from WorldEdit. type:bug Incorrect behavior, not working as intended

Comments

@molor
Copy link

molor commented Jan 13, 2022

WorldEdit Version

7.2.9-SNAPSHOT+6045-3fa364b

Platform Version

git-Paper-141 (MC: 1.18.1)

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

/forestgen generates new trees above existing ones.

image

Expected Behavior

Before update to 1.18.1, in version 1.17.1, it worked correctly and doesn't place dirt blocks inside leaves. I expect that in the new version it should work the same way.

Reproduction Steps

  1. Go to plains;
  2. Use /forestgen multiple times

Anything Else?

No response

@molor molor added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels Jan 13, 2022
@wizjany wizjany added status:accepted Will be fixed / added to WorldEdit, eventually status:upstream This issue should be handled upstream from WorldEdit. and removed status:pending Pending acceptance or closure. labels Jan 13, 2022
@wizjany
Copy link
Collaborator

wizjany commented Jan 13, 2022

this is an issue with changes in mojang's tree generation code. unsure if this was intentional but we may have to do extra validity check that they did previously and don't now.

@octylFractal octylFractal pinned this issue Feb 24, 2022
@octylFractal octylFractal modified the milestones: 7.2.11, Future Jun 8, 2022
octylFractal added a commit that referenced this issue Jun 8, 2022
This fix only applies to Forge/Fabric, and it still produces floating
trees... but it's better than nothing
@octylFractal

This comment was marked as off-topic.

@DrBMello
Copy link

Hi, I was wondering if there's any work around for this issue?

@bl4ckv01d
Copy link

bl4ckv01d commented Jul 27, 2023

Me too. The command //forest works fine on flat area... but as soon as the terrain gets difference in elevation, trees start stacking on top of eachother. Super annoying to get rid of haha :D

Maybe a solution would be to only allow a tree to spawn on an existing grass_block. Without giving it permission to create one on its own. All the stacked trees have created dirt beneath them...

@0rbitL1
Copy link

0rbitL1 commented Aug 9, 2023

this is also a problem in 1.19.2, does anyone know how to get around this?

@octylFractal
Copy link
Member

There is no workaround AFAIK, fixing this is quite involved because the checks are no longer straightforward. I've taken multiple stabs at it without results.

@octylFractal octylFractal removed this from the 7.2.15 milestone Oct 8, 2023
@churchner420
Copy link

churchner420 commented Nov 7, 2023

Same thing happening to me on the latest version on MC 1.20.2... Additionally, the trees also generate on water surfaces not just on top of each other...
From what I've seen so far in this issue tracker, the issue can't be worked out... Could you please remove it then? Forestgen completely unusable atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually status:upstream This issue should be handled upstream from WorldEdit. type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

No branches or pull requests

9 participants