Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines 243: The protein sequence database used including the exact version/date of download (if a release version is not available) are described #34

Open
viikiid opened this issue May 27, 2019 · 3 comments
Assignees
Labels
guidelines All issues referring to the guidelines document.

Comments

@viikiid
Copy link

viikiid commented May 27, 2019

The description of that guideline does not really make sense to me:
"If the original FASTA file from the resource is not transform/change and the release number of the file is not available; the exact version/date of the downloaded FASTA file should be provided."

Do you want to say, that the original file should not be changed? Or do you want to say, that either the release version or an exact download date should be provided? Or both?

@viikiid viikiid added the guidelines All issues referring to the guidelines document. label May 27, 2019
@jgriss
Copy link
Collaborator

jgriss commented Jun 7, 2019

Hi @viikiid What we tried to say is

  • Name the sequence database
  • Reference the version
  • If there is no version, state when it was downloaded

Any ideas how to better phrase this?

@mlocardpaulet
Copy link
Contributor

Maybe you should just say it exactly like that (your bullet points are clear to me)

@jgriss
Copy link
Collaborator

jgriss commented Jun 11, 2019

Here's an updated suggestion:

Name: The used protein sequence database must be unambiguously referenced 
Category: Bronze    
Description: During the protein identification step, the spectrum identification search engine algorithm
commonly uses a  protein sequence FASTA database from public resources (e.g. ENSEMBL, Uniprot). 
The source of the database including the exact version must be named. If a version is not available, 
the date of download must be reported instead. This is **only** applicable to cases where the original 
sequence database was **not modified** (ie, no variants added, etc).
Fields: Proteomics, ProteoGenomics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines All issues referring to the guidelines document.
Projects
None yet
Development

No branches or pull requests

3 participants