Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide warning if listening on '**' and wildcard not set. #237

Open
robertkeizer opened this issue Oct 5, 2018 · 1 comment
Open

Provide warning if listening on '**' and wildcard not set. #237

robertkeizer opened this issue Oct 5, 2018 · 1 comment

Comments

@robertkeizer
Copy link

Would be a nice to have.

Quick look at the code for .on looks like it would be fairly trivial.

Making the assumption that if you're using EventEmitter2 and listening on ** you want to listen on all events. I think that's reasonable. Thoughts?
@RangerMauve
Copy link
Contributor

That sounds like it'd be non-breaking and good to have.

A PR which adds this would be welcome. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertkeizer @RangerMauve