-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: rewrite source in typescript #277
Comments
Interesting idea. Would it be worth it to maybe create a new library which includes all this fancy TS stuff? |
@RangerMauve I have made that consideration, but also considered existing consumer experience to avoid adoption discovery. The implementation architecture for consuming the library would ultimately remain the same, but providing strongly typed source code to support clarity of maintenance and logic. Did you have a specific reservation or objection to migrating the current library? |
IMHO there are no practical reasons to rewrite the lib in TS.
|
Yeah, TS seems like it's popular, but personally I'd like to prioritize what the maintainers are comfortable with, so it might be best to go with a new TS-specific EventEmitter library rather than changing this one so drastically. Thank you for floating the idea by though! Gonna close this for now unless some more maintainers are interested in discussing this further. 😁 |
I can clearly see who is against TypeScript in a general perspective (@DigitalBrainJS ), or usage strongly typed languages, or rather is it just new technologies still existing under the sum total adoption? In any answer, with respect; sadly your objection is weight purely by informal and formal fallacious arguments so I have to refute most of your listed objections. A majority of your bullet items are subjective and are indicative of a biased opinion. Likely due to limited visibility, experience, knowledge of migration success rates of heavily adopted libraries, or negative peers, articles which made objections in a similarly shared approach using inferred subjective speech; detailing a couple issues with truthiness within a finite number of workflows easily avoided or substituted with minor degradation if any. Then surrounding it with own objections to influence disproportionate interpretation to manipulatively persuade holistic opinionated beliefs. Maybe even showing a statistical analysis and/or graph easily identifiable as fake, lacking authenticity or validity after completing the first week of statistics class. Contextually speaking, amongst vendors and engineering teams whom of which history has proven observable empirical evidence of maintaining strict contribution guidelines, often deny and close PRs/Issues simply due to roadmaps and/or frequent mentions lacks evidence of the request, or even more commonly seen with arbitrary edge cases; in perspective, core maintainers, owners and directors have focused targets possessing dedications demonstrating the acknowledgment of constituting facets comparative to maintainability, readability, supporting all major and minor adoptions of surrounding technologies to enable reaching the largest potential number of targeted consumer audience from providing compatibility in both progressive and backwards direction. |
Proposing refresh ⟳ to rewrite core into TypeScript
It would be great to give this library a refresh ⟳ since its initial implementation design, additionally bringing some of the new ES2018+ features. I am more than willing to revel my efforts to achieve these goals.
This issue should serve the purpose of the TS rewrite proposal discussions and outline for new architectural updates (if any) and the new capabilities and/or ES+TS features desired.
ES/TS feature harnessing proposals
function* || closure
,yield
,next()
for emit augmentprivate || protected
property accessors#private
truly private names, solves EventEmitter properties are iterable #178Architectural change proposals
The text was updated successfully, but these errors were encountered: