Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who to contact for security issues #244

Open
JamieSlome opened this issue Feb 7, 2022 · 9 comments
Open

Who to contact for security issues #244

JamieSlome opened this issue Feb 7, 2022 · 9 comments

Comments

@JamieSlome
Copy link

Hey there!

I belong to an open source security research community, and a member (@Sampaguitas) has found an issue, but doesn’t know the best way to disclose it.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

@JamieSlome
Copy link
Author

Just for reference, the report can be found here:
https://huntr.dev/bounties/dc9e467f-be5d-4945-867d-1044d27e9b8e/

It is private and only accessible to maintainers with repository write permissions 👍

@JamieSlome
Copy link
Author

(cc) @rexxars 👆

@ghost
Copy link

ghost commented May 20, 2022

Hi, sorry for hijacking this issue but could you please take a look at approving v1.1.1 for fixing the above mentioned issue too? I am using a tool called snyk and the CVE seems to now acknowledge version 1.1.1 to contain the fix just yet.

@rexxars
Copy link
Member

rexxars commented May 20, 2022

could you please take a look at approving v1.1.1 for fixing the above mentioned issue too?

Do you know how I could go about doing so?

@JamieSlome
Copy link
Author

@rexxars - I might be able to help here. If you can confirm that v1.1.1 is not affected by this, I can update the CVE 👍

See:
https://github.com/418sec/cvelist/blob/master/2022/1xxx/CVE-2022-1650.json

@ghost
Copy link

ghost commented May 20, 2022

could you please take a look at approving v1.1.1 for fixing the above mentioned issue too?

Do you know how I could go about doing so?

Sorry, but I'm not familiar with this process at all :( Jamie seems to be able to assist with it though 💯

@Sampaguitas
Copy link

Sampaguitas commented May 20, 2022 via email

@rexxars
Copy link
Member

rexxars commented May 23, 2022

@rexxars - I might be able to help here. If you can confirm that v1.1.1 is not affected by this, I can update the CVE 👍

See: https://github.com/418sec/cvelist/blob/master/2022/1xxx/CVE-2022-1650.json

To summarize:

  • v1.1.0 and below are affected by this issue - the issue is fixed in v1.1.1.
  • v2.0.0 and v2.0.1 are affected by this issue - the issue is fixed in v2.0.2.

This ensures that people do not have to upgrade to v2 if they are stuck on the v1 range, due to needing support for node 12 or below, or similar.

Would be great if you could update the CVE.

@JamieSlome
Copy link
Author

@rexxars - sorted:

https://github.com/CVEProject/cvelist/pull/5853/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants